chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm-workspace.yaml and pnpm-lock.yaml files to point to new versions of the @voidzero-dev/vite-plus packages. The reviewer identified a high-severity issue where using the PR number (@1633) in the workspace catalog leads to package duplication in the lockfile because the internal dependencies are pinned to a specific commit hash. To resolve this, the reviewer suggests using the full commit hash URL for all @voidzero-dev/* packages in the catalog to ensure proper deduplication and prevent potential runtime issues.
| vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1633 | ||
| vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633 |
There was a problem hiding this comment.
Using the PR number (@1633) in the catalog for vite and vitest is causing package duplication in the lockfile. The vite-plus@1633 package internally pins its dependencies to a specific commit hash (@428629ad4076431fdbeb332ba7c91935e32f92f6), as seen in the pnpm-lock.yaml changes (e.g., lines 3490 and 3502). This results in two versions of the core packages being installed simultaneously. To ensure proper deduplication and avoid potential runtime issues or plugin incompatibilities, it is recommended to use the same commit hash URL for all @voidzero-dev/* packages in the catalog.
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@428629ad4076431fdbeb332ba7c91935e32f92f6
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@428629ad4076431fdbeb332ba7c91935e32f92f6
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@428629ad4076431fdbeb332ba7c91935e32f92f6
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan