Skip to content

chore(deps): bump vite-plus to 0.1.21-alpha.7#3

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7
Draft

chore(deps): bump vite-plus to 0.1.21-alpha.7#3
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 13, 2026

Summary

Bump vite-plus and related packages to alpha 0.1.21-alpha.7.

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs
  • minimumReleaseAgeExclude / minimumReleaseAgeExcludes configured for pnpm + bun

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 13, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of vite, vite-plus, and vitest to a specific alpha release in package.json and introduces a minimumReleaseAgeExclude configuration in pnpm-workspace.yaml. The reviewer suggests pluralizing the new configuration key to minimumReleaseAgeExcludes for consistency and questions its placement in pnpm-workspace.yaml, noting that it is not a standard field and might be better suited for package.json or a tool-specific configuration file like .tazerc.

Comment thread pnpm-workspace.yaml
packages:
- "packages/**"
- playground
minimumReleaseAgeExclude:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The field name minimumReleaseAgeExclude appears to be a typo or inconsistent with the PR description, which mentions both minimumReleaseAgeExclude and minimumReleaseAgeExcludes. Given that the packages field is plural and this field contains a list of multiple items, it should likely be pluralized to minimumReleaseAgeExcludes to maintain consistency with standard YAML configuration patterns in this file and to match the plural form mentioned in the PR summary.

minimumReleaseAgeExcludes:

Comment thread pnpm-workspace.yaml
Comment on lines +4 to +6
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions that minimumReleaseAgeExclude is configured for both pnpm and bun. However, pnpm-workspace.yaml is a configuration file specific to pnpm and is not recognized by bun. For bun, configuration should typically reside in bunfig.toml. Additionally, minimumReleaseAgeExclude is not a standard field in pnpm-workspace.yaml. If this is intended for a tool like taze (which is used in the root package.json), it should be placed in the package.json under a "taze" key or in a .tazerc file, as taze does not natively read from pnpm-workspace.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant