chore(deps): bump vite-plus to 0.1.21-alpha.7#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vite, vite-plus, and vitest to a specific alpha release in package.json and introduces a minimumReleaseAgeExclude configuration in pnpm-workspace.yaml. The reviewer suggests pluralizing the new configuration key to minimumReleaseAgeExcludes for consistency and questions its placement in pnpm-workspace.yaml, noting that it is not a standard field and might be better suited for package.json or a tool-specific configuration file like .tazerc.
| packages: | ||
| - "packages/**" | ||
| - playground | ||
| minimumReleaseAgeExclude: |
There was a problem hiding this comment.
The field name minimumReleaseAgeExclude appears to be a typo or inconsistent with the PR description, which mentions both minimumReleaseAgeExclude and minimumReleaseAgeExcludes. Given that the packages field is plural and this field contains a list of multiple items, it should likely be pluralized to minimumReleaseAgeExcludes to maintain consistency with standard YAML configuration patterns in this file and to match the plural form mentioned in the PR summary.
minimumReleaseAgeExcludes:| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The PR description mentions that minimumReleaseAgeExclude is configured for both pnpm and bun. However, pnpm-workspace.yaml is a configuration file specific to pnpm and is not recognized by bun. For bun, configuration should typically reside in bunfig.toml. Additionally, minimumReleaseAgeExclude is not a standard field in pnpm-workspace.yaml. If this is intended for a tool like taze (which is used in the root package.json), it should be placed in the package.json under a "taze" key or in a .tazerc file, as taze does not natively read from pnpm-workspace.yaml.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan