Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's core dependencies, including vite, vite-plus, and vitest, to specific preview versions. It also introduces release age constraints in .npmrc and pnpm-workspace.yaml. Feedback suggests removing the new entries in pnpm-workspace.yaml as they are non-standard and redundant with the .npmrc configuration.

Comment thread pnpm-workspace.yaml
Comment on lines +5 to +8
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The minimumReleaseAge and minimumReleaseAgeExclude keys are not standard configuration options for pnpm-workspace.yaml. PNPM configuration should be placed in .npmrc (as min-release-age in seconds) or within the pnpm field in package.json. Since these are already correctly configured in .npmrc (lines 2-3), these entries in the workspace file are redundant and likely ignored by the package manager. Additionally, the use of different units (minutes vs. seconds) between the two files could lead to maintenance confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant