chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project's core dependencies, including vite, vite-plus, and vitest, to specific preview versions. It also introduces release age constraints in .npmrc and pnpm-workspace.yaml. Feedback suggests removing the new entries in pnpm-workspace.yaml as they are non-standard and redundant with the .npmrc configuration.
| minimumReleaseAge: 4320 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The minimumReleaseAge and minimumReleaseAgeExclude keys are not standard configuration options for pnpm-workspace.yaml. PNPM configuration should be placed in .npmrc (as min-release-age in seconds) or within the pnpm field in package.json. Since these are already correctly configured in .npmrc (lines 2-3), these entries in the workspace file are redundant and likely ignored by the package manager. Additionally, the use of different units (minutes vs. seconds) between the two files could lead to maintenance confusion.
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan