-
Notifications
You must be signed in to change notification settings - Fork 1
Add scene save/load via glTF #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
24b1c4b
Add scene save/load via glTF with multi-entity skeleton support
fernandotonon 8a072d1
Address code review feedback on scene save/load PR
fernandotonon 5539f57
Fix crash on scene load with skeleton debug, ViewCube z-order, and CI…
fernandotonon eb5d821
Fix ViewCube z-order: use QQuickWidget with lowered NSWindow level on…
fernandotonon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: fernandotonon/QtMeshEditor
Length of output: 49671
🏁 Script executed:
Repository: fernandotonon/QtMeshEditor
Length of output: 20759
🏁 Script executed:
cat -n src/ViewCube/ViewCubeController.cpp | head -100Repository: fernandotonon/QtMeshEditor
Length of output: 3852
Restore
Windowroot and add the missingQt::WindowStaysOnTopHintflag.Line 4 changes the root to
Rectangle, which cannot carry window flags and makes this component non-compliant with the ViewCube rendering contract. Even thoughViewCubeController.cppapplies flags in C++, it is missingQt::WindowStaysOnTopHint(only setsFramelessWindowHintandTool). The guideline explicitly requires all three flags along with software rendering backend to avoid GL conflicts with Ogre.Suggested patch (QML side)
Additionally, ensure
ViewCubeController::initWidget()enforces software rendering for this widget (e.g.,QQuickWindow::setGraphicsApi(QSGRendererInterface::Software)on the QQuickWidget's window).📝 Committable suggestion
🤖 Prompt for AI Agents