Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocap Slice B (#871): ENABLE_MOCAP build infra + VideoFrameSource (Qt Multimedia) #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Mocap Slice B (#871): ENABLE_MOCAP build infra + VideoFrameSource (Qt Multimedia) #880
Changes from all commits
858b973File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 101 in src/Mocap/VideoFrameSource.cpp
This call always selects "FileFrameSource::stop" without considering overrides in subclasses. Ensure the code unambiguously uses the desired function.
Check warning on line 164 in src/Mocap/VideoFrameSource.cpp
implicit conversion from 'qint64' (aka 'long long') to 'double' may lose precision
Check warning on line 165 in src/Mocap/VideoFrameSource.cpp
Extract this nested conditional operator into an independent statement.
Check warning on line 165 in src/Mocap/VideoFrameSource.cpp
implicit conversion from 'qint64' (aka 'long long') to 'double' may lose precision
Check failure on line 196 in src/Mocap/VideoFrameSource.cpp
This call always selects "CameraFrameSource::stop" without considering overrides in subclasses. Ensure the code unambiguously uses the desired function.
Check warning on line 229 in src/Mocap/VideoFrameSource.cpp
Use the init-statement to declare "formats" inside the if statement.
Check warning on line 274 in src/Mocap/VideoFrameSource.cpp
implicit conversion from 'qint64' (aka 'long long') to 'double' may lose precision
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.