add source distribution step to workflow#51
Conversation
|
Ahh, not the error I expected but makes sense. Added the numpy dep and bumped the setup.py version so the upload doesn't collide with any 10.2 versions already uploaded. Ran a test workflow in my repo and other than an obvious pypi authentication issue, looks like everything should be right now. Both wheels and the tar.gz were ready to be uploaded. |
|
@abrammer The alpha seems to be working now. I had to install numpy manually in a fresh virtualenv before I could import |
|
Awesome, yeah I see the wheels on test pypi and a pip install works. For the numpy issue, I think I know the answer. the I think in both those files you can point at a requirements.txt but given it's a single dependency, repeating it once is probably the easier option here. |
fhs
left a comment
There was a problem hiding this comment.
So, with alpha3, it tries to build numpy because test.pypi.org doesn't have the binaries. The build fails for me probably because the numpy version on test.pypi.org is really old.
I think it'll work once I push to the main pypi.org site. Great work!
|
Awesome, yeah would think the same about it pulling from the same pypi url. Just make sure to update the You already did that. Nice. fingers crossed. |
|
It worked. 🎉 |
Add source distribution to wheelhouse directory for artifact and pypi upload. Follow on from #49.
Note, I think this will work, but don't have experience actually doing this specific step for upload to pypi. Might be worth pushing an alpha release branch just to test this whole workflow. A branch with the version
0.10.3a1or similar pre-release version number with a tag should get uploaded to test.pypi without doing anything to master or real pypi.