fix: avoid clearing active filter text in delayed desktop.ini task - #18819
Closed
marko1olo wants to merge 4 commits into
Closed
fix: avoid clearing active filter text in delayed desktop.ini task#18819marko1olo wants to merge 4 commits into
marko1olo wants to merge 4 commits into
Conversation
…s (Marko1olo Custom Fork License))
|
|
Member
|
Duplicate of #18809 also has many unnecessary changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #18807.
When opening a folder with the filter bar enabled, typing into the filter textbox shortly after navigation starts gets wiped out 1–2 seconds later when the directory load finishes.
Cause
NavigateToPathinModernShellPage.xaml.csalready resetsShellViewModel.FilesAndFoldersFilter = null;when navigation begins. However,desktopIniUpdateTaskwas scheduled onDispatcherQueuePriority.Lowand also setFilesAndFoldersFilter = null;upon completion, clearing whatever filter query the user had already entered while the folder was loading.Solution
Remove the redundant and delayed
FilesAndFoldersFilter = null;fromdesktopIniUpdateTask.