test: improve proxy route test coverage#1025
Merged
Merged
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 73.22% 75.62% +2.39%
==========================================
Files 55 55
Lines 2241 2244 +3
Branches 249 251 +2
==========================================
+ Hits 1641 1697 +56
+ Misses 570 517 -53
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for
/src/proxy/routes. Overall project coverage should increase by ~5%.Originally, I wanted to improve coverage for
/plugin.ts, however I've been having problems with the tests not executing due to an ESM interop problem when using theplugin-loaderlibrary.I added a
skipon all the problematic tests inplugin.test.js, and kept the ones that do work.I tried a few workarounds (such as executing with regular
mocha+tsxloader, running withvitest) without any luck. The only working solution I found so far is to upgrade to Node 22.