Skip to content

chore: drop node 20 support#1462

Merged
jescalada merged 7 commits into
mainfrom
1456-drop-node-20-support
Mar 22, 2026
Merged

chore: drop node 20 support#1462
jescalada merged 7 commits into
mainfrom
1456-drop-node-20-support

Conversation

@jescalada

Copy link
Copy Markdown
Contributor

Fixes #1456

Also fixes vulnerable dependencies via npm audit fix

@jescalada jescalada requested a review from a team as a code owner March 16, 2026 14:04
@netlify

netlify Bot commented Mar 16, 2026

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 4fa50d3
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69bb7da6deef0c0008593448

@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (758b2db) to head (4fa50d3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada

Copy link
Copy Markdown
Contributor Author

Running npm audit fix seems to have broken the license check... The new license being added is Artistic-2.0, which appears to be harmless and comes from the Perl Foundation.

I'll add it to the allowed licenses for now. If inappropriate, I'm happy to revert the flatted dependency to the previous version 👍🏼

@jescalada jescalada mentioned this pull request Mar 16, 2026
4 tasks
@jescalada jescalada requested a review from coopernetes March 16, 2026 14:43

@re-vlad re-vlad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider mention changes into CHANGELOG so that the change is visible for anyone troubleshooting an unexpected engine mismatch after upgrading.

Comment thread package.json
Comment thread .github/workflows/experimental-inventory-ci.yml
Comment thread CONTRIBUTING.md
Comment thread .github/workflows/ci.yml Outdated
@jescalada jescalada force-pushed the 1456-drop-node-20-support branch from 259cc3c to e75310d Compare March 18, 2026 14:51
@jescalada

jescalada commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

@kriswest Ready for a look! Somehow the diff got butchered when trying to rebase, so I ended up merging in main instead...

@jescalada jescalada merged commit ec0a993 into main Mar 22, 2026
27 of 30 checks passed
@jescalada jescalada deleted the 1456-drop-node-20-support branch April 9, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Node 20 support

3 participants