Skip to content

feat: format violation text output on a blocked push #789

Merged
JamieSlome merged 2 commits into
finos:mainfrom
Citi:feature/format-violations-on-block
Nov 12, 2024
Merged

feat: format violation text output on a blocked push #789
JamieSlome merged 2 commits into
finos:mainfrom
Citi:feature/format-violations-on-block

Conversation

@saibhotla

Copy link
Copy Markdown
Contributor

feat: format violations on block

feat: format violations on block

feat: improve test
@netlify

netlify Bot commented Nov 12, 2024

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 0149576
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6733820c0ec5c600082a0ebf
😎 Deploy Preview https://deploy-preview-789--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecov Bot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.11%. Comparing base (1e35b93) to head (0149576).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/proxy/processors/push-action/getDiff.js 16.66% 5 Missing ⚠️
src/proxy/processors/push-action/scanDiff.js 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   60.12%   63.11%   +2.98%     
==========================================
  Files          47       47              
  Lines        1650     1678      +28     
==========================================
+ Hits          992     1059      +67     
+ Misses        658      619      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread test/scanDiff.test.js

@JamieSlome JamieSlome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 79284c1 into finos:main Nov 12, 2024
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
…lock

feat: format violation text output on a blocked push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants