fix: ERR_MODULE_NOT_FOUND when sample plugins ran#811
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
=======================================
Coverage 63.11% 63.11%
=======================================
Files 47 47
Lines 1681 1681
=======================================
Hits 1061 1061
Misses 620 620 ☔ View full report in Codecov by Sentry. |
- move plugin sample README into the package so its viewable on npm - fix bad imports from ESM plugin (index.js) - bump @finos/git-proxy-plugin-samples to 0.1.1 - update docs with simpler setup instructions Signed-off-by: Thomas Cooper <thomas.cooper@rbc.com>
a68802c to
db61452
Compare
Signed-off-by: Thomas Cooper <thomas.cooper@rbc.com> Signed-off-by: Thomas Cooper <thomas.cooper@rbc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #812
Testing:
With fixes applied
Current state
Signed-off-by: Thomas Cooper thomas.cooper@rbc.com