Skip to content

Enable CHANGELOG check globally #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlazo merged 2 commits into from
Oct 3, 2022
Merged

Enable CHANGELOG check globally #4084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc61f47
Enable CHANGELOG check globally
rlazo Sep 13, 2022
796ccc7
Simplify conditional.
rlazo Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions ci/danger/Dangerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,28 +71,13 @@ def has_sdk_changes()
}
end

tester_team = [
'rlazo',
'vkryachko',
'yifanyang',
'VinayGuthal',
'davidmotson',
'daymxn',
'emilypgoogle'
]

is_enabled = true if tester_team.include? github.pr_author

### Actions

# Warn if a changelog is left out on a non-trivial PR that has modified
# SDK source files.
#
# TODO: remove the `is_enabled` after tests are complete
if is_enabled && has_sdk_changes()
if !has_changelog_changes && !declared_trivial
warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\
" label to the PR to silence this warning.)"
warn(warning)
end
if has_sdk_changes() && !has_changelog_changes && !declared_trivial
warning = "Did you forget to add a changelog entry? (Add the 'no-changelog'"\
" label to the PR to silence this warning.)"
warn(warning)
end