Fix fidchangelistener behavior#8193
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where FidListener was not invoked when a Firebase Installation ID (FID) is created. The logic was updated to notify listeners when a FID is newly registered or its registration status changes to registered, and corresponding unit tests were added. Feedback on the pull request suggests correcting a typo in the CHANGELOG.md entry to match the class name FidListener.
|
|
||
| private synchronized void checkAndUpdateFidListeners( | ||
| PersistedInstallationEntry prefs, PersistedInstallationEntry updatedPrefs) { | ||
| if (!fidListeners.isEmpty() && shouldNotifyFidListener(prefs, updatedPrefs)) { |
There was a problem hiding this comment.
Do you really need to check if it's empty? The loop by itself will do nothing if there are no listeners registered
There was a problem hiding this comment.
It was there prior so kept it. Removed the isEmpty check right now. Please check.
4 participants
Fixing fidchangelistener behavior to get invoked for new fid creations as well