Skip to content

Add a directive over === false which is an antipattern. #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christhompsongoogle merged 2 commits into from
Mar 11, 2026
Merged

Add a directive over === false which is an antipattern. #10064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e361683
Add a directive over `=== false` which is an antipattern.
christhompsongoogle Mar 10, 2026
069f20a
Merge branch 'main' into equalsFalse
christhompsongoogle Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GEMINI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ npm run format # Auto-fix formatting issues

- **Never use `any` or `unknown` as an escape hatch.** Define proper interfaces/types or use type guards.
- Use strict null checks and handle `undefined`/`null` explicitly.
- **Prefer falsy checks over explicit boolean comparisons:** Use `!something` instead of `something === false` unless you explicitly need to distinguish between `false` and other falsy values like `undefined` or `null`.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To make this guideline more comprehensive, consider expanding it to also discourage === true and promote general truthy/falsy checks. This would provide a more complete rule for boolean comparisons.

Suggested change
- **Prefer falsy checks over explicit boolean comparisons:** Use `!something` instead of `something === false` unless you explicitly need to distinguish between `false` and other falsy values like `undefined` or `null`.
- **Prefer truthy/falsy checks over explicit boolean comparisons:** Use `if (something)` and `if (!something)` instead of `if (something === true)` and `if (something === false)`. An explicit comparison to `false` is only necessary when you need to distinguish it from other falsy values (like `null` or `undefined`).


### Testing

Expand Down
Loading