Move .agent to .agents#10076
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a minor refactoring by renaming the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames the .agent directory to .agents. However, the change is incomplete. A reference to the old directory name remains in the firebase.json configuration created by the createFirebaseConfigs function. This should be updated to ensure the new .agents directory is correctly ignored during deployments.
| appName: string, | ||
| ): Promise<void> { | ||
| const agentDir = path.join(rootPath, ".agent"); | ||
| const agentDir = path.join(rootPath, ".agents"); |
There was a problem hiding this comment.
While this directory name is updated correctly, a related reference in the createFirebaseConfigs function was missed. On line 348, the ignore list for apphosting in the generated firebase.json still refers to ".agent". Please update it to ".agents" to ensure the directory is correctly ignored during deployments.
Move .agent to .agents