Update Firestore Emulator to v1.21.0#10427
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Firestore Emulator to version 1.21.0, adding support for subqueries and new stages, and allowing database-edition per-database. The CHANGELOG.md has been updated accordingly. However, there is an inconsistency in src/emulator/downloadableEmulatorInfo.json where the version field is set to 1.20.3 while the remoteUrl and downloadPathRelativeToCacheDir correctly point to 1.21.0. This version field should be updated to 1.21.0 for consistency.
|
Extreme nit, but I noticed that in the "Scenarios Tested" section in the description, there's no line indicating the version of the emulator being used. Is there a way we verify that? See #10127 for reference, but what I was looking for was something like |
That line is only shown the first time you run with a version (since we only download it once and cache). I'm unconcerned since the integration tests are passing on CI (and those would fail if there was a checksum or size mismatch), but if you want to get it again you can |
That's a good catch! I did run this multiple times, the first time there's a version showed up so I didn't pay a lot of attention afterwards and just copied the output from a latter run... Cleaned the cache and updated the output in the description, thanks both! |
Description
This PR updates the Firestore Emulator to v1.21.0
Scenarios Tested