Nuxt support #5321
Merged
Nuxt support #5321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.30% // Head: 56.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
- Coverage 56.30% 56.26% -0.05%
==========================================
Files 315 317 +2
Lines 21348 21402 +54
Branches 4353 4365 +12
==========================================
+ Hits 12020 12041 +21
- Misses 8287 8312 +25
- Partials 1041 1049 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* refactor the Nuxt 2 build workflow to accommodate all the ssr/target combinations * eliminated some eslint warnings * abstracted some common methods outside the main nuxt file * started using some interfaces * started testing scripts
jamesdaniels
approved these changes
Jan 26, 2023
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM better than what we have. Add changelog and can you fix Austin's email in a force-push?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles basic Nuxt 2 and Next 3 support.
Scenarios Tested
Covers basic Nuxt 3 with limited configuration.
Nuxt 2 has a couple more use cases, but the following should be handled:
ssr: falsessr: truetarget: 'server'target: 'static'Sample Commands
Deploying Nuxt 2 and 3 codebase via
firebase emulators:start.