fix(firebase_ui_localizations): fixed register translation for turkish#11339
Merged
Conversation
Member
|
Hey @atillaturkmen, any chance you can get this proof read by a fellow Turikish speaking dev? i.e. get this PR "approved" by someone else who speaks Turkish? Thanks. |
|
@russellwheatley I speak Turkish and I can say @atillaturkmen's word choice is correct. Kaydet means simply to save, as in saving a record or a file. Kaydedin means you(the user) saves that record. Kaydol means sign up/register. Kaydolun means you(the user) can sign up or register. Before the change, it basically says save instead of sign up. Even a simple google translate of the words "sign up" or "register" to Turkish gives kaydol. |
russellwheatley
approved these changes
Aug 1, 2023
lesnitsky
approved these changes
Aug 1, 2023
kutlayhanli
pushed a commit
to kutlayhanli/flutterfire
that referenced
this pull request
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Turkish translation for the
registerActionTextandregisterTextin thefirebase_ui_localizationsfile. The changes ensure more accurate translations, replacing "Kaydet" with "Kaydol" for "registerActionText" and "Kaydedin" with "Kaydolun" for "registerText" This modification improves the user experience for Turkish-speaking users.Related Issues
This PR resolves the following issue in the issue database:
Checklist
Before creating this PR, I have confirmed the following:
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?