Skip to content

fix(firebase_ui_localizations): fixed register translation for turkish#11339

Merged
russellwheatley merged 4 commits into
firebase:masterfrom
atillaturkmen:master
Aug 2, 2023
Merged

fix(firebase_ui_localizations): fixed register translation for turkish#11339
russellwheatley merged 4 commits into
firebase:masterfrom
atillaturkmen:master

Conversation

@atillaturkmen

Copy link
Copy Markdown
Contributor

Description

This PR updates the Turkish translation for the registerActionText and registerText in the firebase_ui_localizations file. The changes ensure more accurate translations, replacing "Kaydet" with "Kaydol" for "registerActionText" and "Kaydedin" with "Kaydolun" for "registerText" This modification improves the user experience for Turkish-speaking users.

Related Issues

This PR resolves the following issue in the issue database:

Checklist

Before creating this PR, I have confirmed the following:

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley

Copy link
Copy Markdown
Member

Hey @atillaturkmen, any chance you can get this proof read by a fellow Turikish speaking dev? i.e. get this PR "approved" by someone else who speaks Turkish? Thanks.

@DBC201

DBC201 commented Jul 31, 2023

Copy link
Copy Markdown

@russellwheatley I speak Turkish and I can say @atillaturkmen's word choice is correct. Kaydet means simply to save, as in saving a record or a file. Kaydedin means you(the user) saves that record. Kaydol means sign up/register. Kaydolun means you(the user) can sign up or register. Before the change, it basically says save instead of sign up. Even a simple google translate of the words "sign up" or "register" to Turkish gives kaydol.

@russellwheatley russellwheatley merged commit 0b9ae72 into firebase:master Aug 2, 2023
kutlayhanli pushed a commit to kutlayhanli/flutterfire that referenced this pull request Aug 18, 2023
@firebase firebase locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants