feat: Full support of AGP 8#11699
Merged
Merged
Conversation
10 tasks
Contributor
Author
|
@russellwheatley Here it is, the updated version of #11318 I would also appreciate if you review #11671 as well. |
Member
|
@vbuberen - thank you for the PRs 🥳 . I will take a look at them next week 😄 |
Member
|
@vbuberen - The CI is failing because of the need for I've built it locally and it doesn't work with |
Closed
10 tasks
Contributor
Author
I will check it out a bit later today. |
Contributor
Author
|
I made a typo there 🤦🏻 |
russellwheatley
approved these changes
Oct 17, 2023
russellwheatley
left a comment
Member
There was a problem hiding this comment.
Great work, @vbuberen 🥳
exaby73
approved these changes
Oct 17, 2023
Lyokone
approved these changes
Oct 17, 2023
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Oct 29, 2023
Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a replacement for #11318 as it was agreed in that PR. Opened another PR as don't have access to push anything to that other fork used to create #11318.
Summary of changes and things to note:
buildFeaturesblock in allbuild.gradlefiles for support of AGP 8.Dropped step to install Java from CI as it is pre-installed on Github runners: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md UPD: Looks like workflow can't pick Java 17 on its own even though it is installed, so brought back the Java setup step.compileSdkVersionusecompileSDK). Note, this would require projects using plugins to have at least AGP 7 as it mentioned here: https://developer.android.com/about/versions/13/setup-sdk3.xversions of AGP after this PR build speed should improve for such packages.jcenter()as it is not reliable and replaced withmavenCentral().-jdk7or-jdk8as it is not needed for quite a long time already and since release1.8.xis the default required way of declaring Kotlin dependency.annotationAndroid dependency in all plugins.gradlefolders in packages where they are not needed.build.gradlefiles so they have the same position of blocks across plugins as it was confusing to update code in different places for every plugin.Related Issues
Closes #11266
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?