[firebase_crashlytics] Logging improvements#1359
Merged
Merged
Conversation
Contributor
Author
|
Since there are now multiple concurrent PRs for firebase_crashlytics, updating PTAL and comment whether this change LGTY and once it is, I will make changes to CHANGELOG and pubspec right away. |
Collaborator
|
LGTM, feel free to bump version |
Contributor
Author
|
Done |
Contributor
Author
|
@kroikie a friendly ping |
collinjackson
approved these changes
Nov 7, 2019
kroikie
pushed a commit
to collinjackson/flutterfire
that referenced
this pull request
Nov 15, 2019
* Do not add verbose current code location to logs * Avoid format string injections * Point out where the logging is coming from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make logging more obvious and to the right point of verbosity.
This change also gets rid of XCode build warnings about potential security issue with format string.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?