Skip to content

fix(firebaseai): Add thoughtSignature during chat session function call#17945

Merged
russellwheatley merged 2 commits into
mainfrom
firebaseai/function_signature
Jan 14, 2026
Merged

fix(firebaseai): Add thoughtSignature during chat session function call#17945
russellwheatley merged 2 commits into
mainfrom
firebaseai/function_signature

Conversation

@cynthiajoan

Copy link
Copy Markdown
Collaborator

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

#17887

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@cynthiajoan

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for thoughtSignature and isThought properties within Part objects, which is a key feature for enabling more advanced model interactions. The implementation is well-executed, featuring a nice refactoring of the toJson serialization logic into the base Part class to improve maintainability and reduce code duplication. The tests have also been updated effectively to cover the new functionality and even improve upon existing test quality. I have identified two minor opportunities for improvement in the JSON parsing logic to make it more robust against potential runtime errors, and have provided suggestions for these.

@russellwheatley russellwheatley merged commit 870d2a0 into main Jan 14, 2026
31 checks passed
@russellwheatley russellwheatley deleted the firebaseai/function_signature branch January 14, 2026 11:12
@firebase firebase locked and limited conversation to collaborators Jul 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants