Skip to content

[cloud_functions] Correct method channel name on iOS #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
izzyaf wants to merge 6 commits into from
Closed

[cloud_functions] Correct method channel name on iOS #2023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9b873a
correct method channel name on iOS to match with the interface
Feb 19, 2020
86bb705
bump & changelog
Feb 19, 2020
51d6297
added authors
Feb 19, 2020
7ed1aa5
Merge branch 'master' into fix-method-channel-name
Feb 20, 2020
f9a1f6d
Merge branch 'master' into fix-method-channel-name
Feb 25, 2020
18ba558
Update pubspec.yaml
Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,5 @@ Michel Feinstein <michel@feinstein.com.br>
Tobias Löfstrand <tobias@leafnode.se>
Stephen Beitzel <sbeitzel@pobox.com>
Mark Veenstra <markdark81@gmail.com>
Le Minh Pham Hoang <le.minh.pham.hoang@gmail.com>
Ben Hagen <ben@ottomatic.io>
4 changes: 4 additions & 0 deletions packages/cloud_functions/cloud_functions/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.4.2+2

* Fixes the regression of `No implementation found for method CloudFunctions#call` on iOS

## 0.4.2+1

* Make the pedantic dev_dependency explicit.
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_functions/cloud_functions/darwin/Classes/CloudFunctionsPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ @implementation CloudFunctionsPlugin

+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
FlutterMethodChannel *channel =
[FlutterMethodChannel methodChannelWithName:@"cloud_functions"
[FlutterMethodChannel methodChannelWithName:@"plugins.flutter.io/cloud_functions"
binaryMessenger:[registrar messenger]];
CloudFunctionsPlugin *instance = [[CloudFunctionsPlugin alloc] init];
[registrar addMethodCallDelegate:instance channel:channel];
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_functions/cloud_functions/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: cloud_functions
description: Flutter plugin for Cloud Functions.
version: 0.4.2+1
version: 0.4.2+2
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions

flutter:
Expand Down