Fix for UserAgent.h issues

[jmagman]

Identical to #2099 but with the firebase_crashlytics CHANGELOG merge issue and analyzer warnings fixed.

Remove the UserAgent.h header in favor of defining LIBRARY_VERSION and LIBRARY_NAME in the GCC_PREPROCESSOR_DEFINITIONS in the podspec.

Fixes #2087
Fixes #1858
Fixes #2084

[jmagman]

New analyzer warning for change introduced in #1686. Fixing in this PR.

Checking project cloud_firestore_platform_interface...

  info - Two keys in a map literal shouldn't be equal at test/method_channel_cloud_firestore_test.dart:1031:19 - (equal_keys_in_map)
  info - Two keys in a map literal shouldn't be equal at test/method_channel_cloud_firestore_test.dart:1055:19 - (equal_keys_in_map)

2 issues found; analyzed 42 source files in 14.0s.

I guess the analyzer options aren't pegged to a version in this repo?
\cc @collinjackson

[jmagman]

Analyzer warning fix: multiple 'source' keys.

[jmagman]

Analyzer warning fix: multiple 'source' keys.

[jmagman]

Manually merged with 4d7b2bd to maintain authorship. Closing.

[Saifallak]

firebase_auth 0.15.5+3 not published yet, can you publish it ? @collinjackson @kroikie @franciscojma86 @jmagman

[awhitford]

Besides firebase_auth, I seem to also still have an issue with firebase_storage:

    /Users/anthony/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_storage-3.1.3/ios/Classes/FLTFirebaseStoragePlugin.m:6:9: fatal error: 'UserAgent.h' file not found
    #import "UserAgent.h"
            ^~~~~~~~~~~~~
    1 error generated.

[mono0926]

@jmagman

Thanks, the build error was fixed 👍
But, after this change, bitcode_strip started failed on iOS project which bitcode enabled.

2020-03-16 02:13:56.970 xcodebuild[26510:54603] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/Runner_2020-03-16_02-13-56.965.xcdistributionlogs'.
error: exportArchive: bitcode_strip failed

Error Domain=IDEFoundationErrorDomain Code=1 "bitcode_strip failed" UserInfo={NSLocalizedDescription=bitcode_strip failed}

[jmagman]

@mono0926 please file a new issue at flutter/flutter and fill out the template so we can take a look.

[ifanchu]

so which version should I use? 0.15.5+2 still seeing same issue.

[DenisBogatirov]

Same UserAgent.h issue on firebase-auth: 0.15.5+2, when 0.15.5+3 will be released?

[Saifallak]

finally it's released now firebase-auth: 0.15.5+3