Skip to content

CI CD test failure fixed#593

Merged
marcvergees merged 1 commit into
fireform-core:developmentfrom
chetanr25:ci_failure_fix
Jun 25, 2026
Merged

CI CD test failure fixed#593
marcvergees merged 1 commit into
fireform-core:developmentfrom
chetanr25:ci_failure_fix

Conversation

@chetanr25

Copy link
Copy Markdown
Collaborator

Fix CI failures: alembic check + docker build

Problem

Two CI jobs failing on PRs:

  • Tests / alembic check - python -m alembic check connected to default postgres at localhost:5432; no DB in CI → connection refused.
  • Docker Build - docker build . looked for ./Dockerfile, which doesn't exist (Dockerfiles live under docker/prod/ and docker/dev/).

Changes

  • tests.yml: added a postgres:16 service container, run alembic upgrade head then alembic check against it with DATABASE_URL set. Also extended PR triggers to development.
  • docker-build.yml: build with -f docker/prod/Dockerfile . (verified COPY paths are repo-root relative).

fixes #592

@chetanr25

Copy link
Copy Markdown
Collaborator Author

With the GitHub Actions job now running successfully, this confirms that the CI/CD fix is complete.
https://github.com/fireform-core/FireForm/actions/runs/28165021483/job/83414713676?pr=593

@marcvergees marcvergees merged commit 752d0d2 into fireform-core:development Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD fails

2 participants