When the display is "Categories" (NOT "Categories with CPU"), incorrect CPU usage is shown in the tooltip

[mstange]

Profile: https://share.firefox.dev/3iglgzE

This profile has CPU usage data, but when displayed "without CPU", the tooltip still shows a CPU usage percentage - and it is wrong. For example, in this profile, during the long jank between seconds 50 and 60, the tooltip shows 100%.

[canova]

Ah, that's because we are actually computing those values in the activity graph for better numbers when there are samples on top of each other. All these numbers will be wrong when the graph is not with the CPU usage. I think best way is to remove the CPU field when we are in the "Categories" view.
Also I was thinking about retiring "Categories" view lately. Maybe it's time to do that?

[mstange]

Both solutions sound good to me.

[julienw]

Is the value also incorrect in "Categories with CPU" when there's an idle category (which is also decreasing the height in addition to the CPU)?

[canova]

I think we are assuming that the idle category will consume ~0 CPU. But that's not correct obviously. We should show the idle if its CPU value is higher.