There should be a context menu item for opening the source view

[mstange]

The source view is not very discoverable at the moment, because it only opens on double click or enter.

We should add a context menu item to open the source view.

[krsh732]

Is it alright if I take this, and if yes, is something like the following fine?

[mstange]

Of course, I'm happy to assign this bug to you. Thank you!

I find it a bit tricky to find the right wording for the menu item label. How about: "Show nsEmbedFunctions.cpp"? (where "nsEmbedFunctions.cpp" is just the filename of the the selected function's full path / URL, i.e. the part after the last slash or backslash)

I think it would also be justified to move this item to the very top of the context menu, with a separator just below it. For example, in a file manager (e.g. Finder on macOS), double-clicking a file opens the file, and consequently, "Open File" is the first item in the file context menu.

Other options for the menu item label:

• Open source view
• Show source view
• Open nsEmbedFunctions.cpp
• Show nsEmbedFunctions.cpp
• Display nsEmbedFunctions.cpp
• Show source code for this function
• Show source code for XRE_InitChildProcess

I think I like "Show nsEmbedFunctions.cpp" the most, but I'm happy to hear other suggestions or arguments.

(Also, we'll probably have to rethink the label once the assembly view lands (#4196), because then double-clicking will update both the shown source file and the shown assembly code, probably... I haven't finalized the UI for the assembly view in my mind just yet, but I'm thinking the assembly view will be hidden by default until it's revealed with another button in the bottom box, and then it'll be shown whenever the bottom box is shown, or something like that, and then there are functions for which we only have source and no assembly and also functions with only assembly but no source, and we don't want to show conflicting things side-by-side in the same box, so we'll have to update both on double-click... Anyway, let's not worry about the assembly view for now and make something that works with the current source-view-only implementation.)

[krsh732]

I liked the "Show <filename>" option the most too, so went with that for the PR. Also moved it to the top with a separator as suggested.