Hiding threads does not resize stack chart canvas

[digitarald]

STR:

• Hide a few threads

ER: Canvas for stack chart resizes to fit

AR: Canvas stays stuck

[jtorre58]

Hello, me and another group member are interested in working on this bug. We are both fairly new to using React (and JavaScript really). Would you have any suggestion on where we should start? Perhaps where the window and canvas are being resized?

[gregtatum]

Thanks for your interest!

These actions are where the visible threads are being changed using action creators:

https://github.com/devtools-html/perf.html/blob/b185dd4b069ef7afa89ab39a7aaaf877a356e49e/src/actions/profile-view.js#L88-L158

I think it would be sufficient to emit a resize event for the browser window, like so:

https://github.com/devtools-html/perf.html/blob/aee3b95a82fee31f54d1b9b7d1ab27f1e5f2d41d/src/components/app/ProfileViewerContainer.js#L20-L23

Finally the StackChart canvas listens to the resize events by using the WithSize component:

https://github.com/devtools-html/perf.html/blob/529cb9a1286d7f3b38bf740855dcb5c09a70159e/src/components/shared/WithSize.js

[jtorre58]

Thank you! We should have a pull request up soon.

[gregtatum]

Feel free to throw up a work in progress PR to get feedback. Just label the PR title "WIP" and we can provide feedback.

[gregtatum]

PR #954 has work that addresses this issue, but wasn't brought over the review finish line. It's open for anyone else to pick up.