#1343 - Upgrade yarn.lock and the tools that check the yarn version#1918
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 185 185
Lines 12947 12947
Branches 3231 3234 +3
=======================================
Hits 10852 10852
Misses 1905 1905
Partials 190 190
Continue to review full report at Codecov.
|
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for the patch! It looks good to me but there is one small thing to change about semver version. You can see the comment below.
Also all CI are green, which is a good sign!
| if (agents.yarn) { | ||
| const version = agents.yarn; | ||
| if (versionCompare(version, '1.0') < 0) { | ||
| if (versionCompare(version, '1.1') < 0) { |
There was a problem hiding this comment.
This is semver versioning and not a floating number, therefore 1.1 != 1.10. It goes like this: 1.9 -> 1.10 -> 1.11. We should use '1.10' here.
For more info: https://semver.org/
…ic Versioning 2.0.0
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for working on this! It looks good to me!
Since pull request firefox-devtools#1918 has been merged, yarn version minimum requirement is now 1.10.
Since pull request firefox-devtools#1918 has been merged, yarn version minimum requirement is now 1.10.
3 participants
I did the things @julienw told to, on #1343 (comment).
@canaltinova