Show the duration of the full range in the filter navigator bar#3964
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3964 +/- ##
==========================================
- Coverage 87.26% 87.26% -0.01%
==========================================
Files 279 279
Lines 23924 23921 -3
Branches 6317 6315 -2
==========================================
- Hits 20877 20874 -3
Misses 2807 2807
Partials 240 240
Continue to review full report at Codecov.
|
| class="filterNavigatorBarItemContent" | ||
| > | ||
| Full Range | ||
| Full Range (51ms) |
There was a problem hiding this comment.
I'm curious: what hidden character do you have, and why is it needed?
There was a problem hiding this comment.
On second thoughts, I guess they are the directionality characters from Fluent, but didn't realize you need to replicate them in tests.
There was a problem hiding this comment.
I believe these are the isolation characters inserted by Fluent automatically
There was a problem hiding this comment.
On second thoughts, I guess they are the directionality characters from Fluent, but didn't realize you need to replicate them in tests.
Well we use Fluent in the tests :-)
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
This looks good to me, thanks!
| <Localized | ||
| id="ProfileFilterNavigator--full-range-with-duration" | ||
| vars={{ | ||
| fullRangeDuration: getFormattedTimeLength( |
There was a problem hiding this comment.
In the future I'd like to replace this with a Fluent function, but that's a story for later...
| > | ||
| <> | ||
| Full Range ( | ||
| {getFormattedTimeLength(rootRange.end - rootRange.start)}) |
There was a problem hiding this comment.
What do you think of not using ({getFormattedTimeLength(rootRange.end - rootRange.start)}) here, since it will be replaced by Fluent anyway, it seems counterproductive to run the full process in this case.
There was a problem hiding this comment.
Yeah, I can remove this. I really want to bite the bullet at some point and remove the texts from all Localized components. But that's a lot of change...
canova
force-pushed
the
full-range-duration
branch
from
0da0324 to
17e8ee5
Compare
3 participants
Fixes #3692
Before:
After:
Deploy preview / Production