Skip to content

Move the IPC tracks right below their threads during the initial load#3968

Merged
canova merged 3 commits into
firefox-devtools:mainfrom
canova:ipc-track-ordering
Apr 5, 2022
Merged

Move the IPC tracks right below their threads during the initial load#3968
canova merged 3 commits into
firefox-devtools:mainfrom
canova:ipc-track-ordering

Conversation

@canova

@canova canova commented Mar 31, 2022

Copy link
Copy Markdown
Member

Fixes #3890.

Previously the IPC tracks were always appearing at the end of the local tracks. But that's not a great user experience when our users need to look at the IPC markers. There are two IPC track cases:

  1. If an IPC track belongs to a global track, we would like to show those tracks right after network and memory tracks and before other threads.
  2. If an IPC track belongs to a local track, we would like to show those tracks right after those local thread tracks.

With this PR fixes those two items.

Some example profiles:

  1. Deploy preview / Production
  2. Deploy preview / Production
  3. Deploy preview / Production

Note that some of the IPC tracks may be visible even though their threads are not. This is because we always show the IPC tracks right now but it will be fixed one #3908 lands.

@canova canova force-pushed the ipc-track-ordering branch from 7398916 to 6c88f4b Compare March 31, 2022 14:20
@canova canova requested a review from julienw March 31, 2022 14:21
@codecov

codecov Bot commented Mar 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3968 (a32bb0e) into main (82019de) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3968      +/-   ##
==========================================
- Coverage   87.26%   87.26%   -0.01%     
==========================================
  Files         279      279              
  Lines       23924    23934      +10     
  Branches     6317     6325       +8     
==========================================
+ Hits        20877    20885       +8     
- Misses       2807     2809       +2     
  Partials      240      240              
Impacted Files Coverage Δ
src/profile-logic/tracks.js 83.33% <83.33%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82019de...a32bb0e. Read the comment docs.

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me!

Only thing that disturbs me is when some IPC track is present but its thread companion isn't. But I guess this is some discussion for later?

Comment on lines 298 to 302
'show [thread GeckoMain tab] SELECTED',
' - show [thread DOM Worker]',
' - show [thread Style]',
' - show [ipc GeckoMain] SELECTED',
' - show [thread DOM Worker]',
' - show [ipc DOM Worker]',
' - show [thread Style]',
' - show [ipc Style]',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

' - show [ipc DOM Worker]',
' - show [thread Style]',
]);
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new test

@canova

canova commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

Thanks, this looks good to me!

Thanks for the review!

Only thing that disturbs me is when some IPC track is present but its thread companion isn't. But I guess this is some discussion for later?

This will be fixed once I land the #3908. I didn't land it yet mostly because I still find it useful to see them all the time while I'm working on them :)

@canova canova force-pushed the ipc-track-ordering branch from 6c88f4b to a32bb0e Compare April 5, 2022 08:28
@canova canova merged commit bb24b1a into firefox-devtools:main Apr 5, 2022
@canova canova mentioned this pull request Apr 5, 2022
@canova canova deleted the ipc-track-ordering branch April 6, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorder the IPC tracks so they will appear right below their threads

2 participants