Move the IPC tracks right below their threads during the initial load#3968
Conversation
7398916 to
6c88f4b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3968 +/- ##
==========================================
- Coverage 87.26% 87.26% -0.01%
==========================================
Files 279 279
Lines 23924 23934 +10
Branches 6317 6325 +8
==========================================
+ Hits 20877 20885 +8
- Misses 2807 2809 +2
Partials 240 240
Continue to review full report at Codecov.
|
julienw
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
Only thing that disturbs me is when some IPC track is present but its thread companion isn't. But I guess this is some discussion for later?
| 'show [thread GeckoMain tab] SELECTED', | ||
| ' - show [thread DOM Worker]', | ||
| ' - show [thread Style]', | ||
| ' - show [ipc GeckoMain] SELECTED', | ||
| ' - show [thread DOM Worker]', | ||
| ' - show [ipc DOM Worker]', | ||
| ' - show [thread Style]', | ||
| ' - show [ipc Style]', |
| ' - show [ipc DOM Worker]', | ||
| ' - show [thread Style]', | ||
| ]); | ||
| }); |
Thanks for the review!
This will be fixed once I land the #3908. I didn't land it yet mostly because I still find it useful to see them all the time while I'm working on them :) |
6c88f4b to
a32bb0e
Compare
Fixes #3890.
Previously the IPC tracks were always appearing at the end of the local tracks. But that's not a great user experience when our users need to look at the IPC markers. There are two IPC track cases:
With this PR fixes those two items.
Some example profiles:
Note that some of the IPC tracks may be visible even though their threads are not. This is because we always show the IPC tracks right now but it will be fixed one #3908 lands.