Skip to content

Rework how publishing sanitized profiles work#3977

Closed
julienw wants to merge 2 commits into
firefox-devtools:mainfrom
julienw:2947-keep-hidden-trakcs-after-sanitization
Closed

Rework how publishing sanitized profiles work#3977
julienw wants to merge 2 commits into
firefox-devtools:mainfrom
julienw:2947-keep-hidden-trakcs-after-sanitization

Conversation

@julienw

@julienw julienw commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

So that hidden tracks and track order states aren't lost.

Fixes #2947

Not ready for review:

  • Make sure that the active tab view works
  • Manual tests
  • Update tests

┆Issue is synchronized with this Jira Task

@julienw julienw marked this pull request as draft April 5, 2022 17:30
@codecov

codecov Bot commented Apr 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3977 (0e81efc) into main (4b5c974) will decrease coverage by 0.11%.
The diff coverage is 68.38%.

@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
- Coverage   87.26%   87.15%   -0.12%     
==========================================
  Files         279      279              
  Lines       23936    24040     +104     
  Branches     6330     6366      +36     
==========================================
+ Hits        20887    20951      +64     
- Misses       2809     2849      +40     
  Partials      240      240              
Impacted Files Coverage Δ
src/reducers/app.js 98.77% <ø> (+0.58%) ⬆️
src/profile-logic/tracks.js 78.60% <48.10%> (-4.86%) ⬇️
src/actions/publish.js 92.85% <95.65%> (+0.07%) ⬆️
src/reducers/profile-view.js 95.86% <100.00%> (+0.01%) ⬆️
src/reducers/publish.js 100.00% <100.00%> (+1.92%) ⬆️
src/reducers/url-state.js 94.90% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5c974...0e81efc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some hidden tracks reappear after sanitization

2 participants