Fix the incorrect first counters on the graphs when zoomed in#4114
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4114 +/- ##
==========================================
- Coverage 88.26% 88.26% -0.01%
==========================================
Files 280 280
Lines 24373 24403 +30
Branches 6473 6490 +17
==========================================
+ Hits 21514 21539 +25
- Misses 2655 2660 +5
Partials 204 204
Continue to review full report at Codecov.
|
canova
force-pushed
the
power-counter-range
branch
from
60c6317 to
3a25880
Compare
canova
changed the title
julienw
approved these changes
Jul 8, 2022
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me!
It would be good to extract the common code eventually...
canova
force-pushed
the
power-counter-range
branch
from
104a5fb to
ac6a6be
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the graphs that use
counters(memory/process-cpu/power) to take the whole samples table and not only the range filtered ones. While passing the whole counter samples, we are also adding a samples range and only computing the samples between that range. Performance of the graphs should be nearly identical. Might be even better for some cases since we don't compute the range filtered samples table on every range change.(I've started this PR for power graph only and changed it to fix other graphs as well) memory and per process cpu should be identical right now compared to the previous code. But see the power track that was incorrect before (due to incorrect first value calculation). Let me know what you think!
Exaple profile for memory and power graphs:
Main branch / Deploy preview
Example profile for per process cpu graph:
Production / Deploy preview