Remove some incorrect conditions from local track isSelected prop#4143
Merged
Conversation
We don't have an event-delay tab, therefore these conditions will always return true.
Codecov Report
@@ Coverage Diff @@
## main #4143 +/- ##
==========================================
+ Coverage 88.26% 88.27% +0.01%
==========================================
Files 280 280
Lines 24392 24388 -4
Branches 6480 6477 -3
==========================================
- Hits 21530 21529 -1
+ Misses 2658 2655 -3
Partials 204 204
Continue to review full report at Codecov.
|
julienw
approved these changes
Jul 18, 2022
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
thanks for the clean-up!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have an event-delay tab, therefore these conditions will always return true.