Fix an issue where a local track wasn't unselected when its global track is hidden#4158
Merged
julienw merged 2 commits intoJul 28, 2022
Merged
Conversation
julienw
changed the title
julienw
commented
Jul 27, 2022
| * ' - show [thread Renderer]', | ||
| * ] | ||
| */ | ||
| function getProfileWithMoreNiceTracks() { |
Contributor
Author
There was a problem hiding this comment.
note: I'll reuse this profile in the tests for #4138
Codecov Report
@@ Coverage Diff @@
## main #4158 +/- ##
==========================================
- Coverage 88.31% 88.31% -0.01%
==========================================
Files 280 280
Lines 24408 24407 -1
Branches 6488 6488
==========================================
- Hits 21555 21554 -1
Misses 2650 2650
Partials 203 203
Continue to review full report at Codecov.
|
julienw
added a commit
to julienw/perf.html
that referenced
this pull request
Jul 27, 2022
…track wasn't unselected when its global track is hidden
canova
approved these changes
Jul 28, 2022
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this issue when working on #4138.
STR is:
=> the old track is still selected
production / deploy preview