Skip to content

Tweak close button styling #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 1 commit into from
Aug 11, 2022
Merged

Tweak close button styling #4178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/components/timeline/Track.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,29 @@
}

.timelineTrackCloseButton {
position: relative;
right: 5px;
overflow: hidden;
width: 11px;
height: 11px;
padding: 0;
width: 15px;
height: 15px;
Comment on lines +67 to +68

@canova canova Aug 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit bigger compared to its previous icon now. I wonder if making it a bit smaller makes it a bit less crowded/flashing. But I don't mind either way tbh. :)

@mstange mstange Aug 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. It takes away the same amount of horizontal space from the label, but I'm happy to make it smaller. We can see how people feel about it.

box-sizing: content-box;
padding: 1px;
border: 0;
background: url(../../../res/img/svg/searchfield-cancel.svg) top left
no-repeat;
margin: 0 2px;
background: url(../../../res/img/svg/close-dark.svg) no-repeat center;
background-origin: content-box;
background-size: contain;
border-radius: 2px;
color: transparent;
margin-inline-start: 8px;
-moz-user-focus: ignore;
}

.timelineTrackCloseButton:hover {
background-color: rgb(0 0 0 / 0.15);
}

.timelineTrackCloseButton:active:hover {
background-color: rgb(0 0 0 / 0.3);
}
Comment thread
mstange marked this conversation as resolved.

.timelineTrackLabel:not(:hover) > .timelineTrackCloseButton {
display: none;
}
Expand Down