Tweak close button CSS some more.#4179
Merged
mstange merged 1 commit intoAug 11, 2022
Merged
Conversation
Add flex-shrink:0 so that the button is square, and reduce its size by removing the box-sizing:content-box (17x17 -> 15x15), and also remove the left margin because the padding in the button is enough.
fqueze
approved these changes
Aug 11, 2022
fqueze
left a comment
fqueze
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks for the quick follow-up!
Codecov Report
@@ Coverage Diff @@
## main #4179 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 280 280
Lines 24528 24528
Branches 6535 6535
=======================================
Hits 21697 21697
Misses 2629 2629
Partials 202 202 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main branch
deploy preview
Add flex-shrink:0 so that the button is square, and reduce its size
by removing the box-sizing:content-box (17x17 -> 15x15), and also
remove the left margin because the padding in the button is enough.