Skip to content

Rename the recent uploaded recordings title to express that they belong to user#4186

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
canova:recent-uploaded-recordings-rename
Aug 16, 2022
Merged

Rename the recent uploaded recordings title to express that they belong to user#4186
canova merged 1 commit into
firefox-devtools:mainfrom
canova:recent-uploaded-recordings-rename

Conversation

@canova

@canova canova commented Aug 15, 2022

Copy link
Copy Markdown
Member

This came up from our conversations in the Matrix channel with :smaug.
It wasn't very clear that the recordings belong to you or someone else before. This PR should clarify things.

@canova canova requested a review from a team as a code owner August 15, 2022 16:51
@codecov

codecov Bot commented Aug 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4186 (fe53964) into main (1272093) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4186   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         280      280           
  Lines       24528    24528           
  Branches     6535     6535           
=======================================
  Hits        21697    21697           
  Misses       2629     2629           
  Partials      202      202           
Impacted Files Coverage Δ
src/components/app/Home.js 71.11% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@canova canova requested a review from mstange August 16, 2022 13:25

@mstange mstange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree that this is clearer.

@canova canova force-pushed the recent-uploaded-recordings-rename branch from 7114d19 to fe53964 Compare August 16, 2022 15:22
@canova canova merged commit b7eba13 into firefox-devtools:main Aug 16, 2022
@canova canova mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants