Add endTime, mainMemory, arguments, symbolicationNotSupported to MetaInfo#4188
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4188 +/- ##
=======================================
Coverage 88.44% 88.44%
=======================================
Files 280 280
Lines 24552 24536 -16
Branches 6548 6543 -5
=======================================
- Hits 21714 21702 -12
+ Misses 2636 2632 -4
Partials 202 202
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flodolo
left a comment
There was a problem hiding this comment.
Please don't touch localized files, only add strings to en-US
|
A sample file: profile.json.zip |
This reverts commit fa22cc4.
canova
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks pretty good to me. I've added some comments, we can land it after they are addressed. Let me know if you have any question.
|
Is there anything for me to do, before it can be merged? |
|
I'd like @canova to take one last look, because he has commented before and not approved yet. |
I want to add three different data points to the meta info (and show it in the MetaInfo box) which are especially helpful for imported profiles.
endTime: time the main process endedmainMemory: size of the main memory (important for server applications)arguments: program argumentssymbolicationNotSupported: if true, hides the symbolication related text and button, important for imported profiles that cannot be symbolicated (or are already symbolicated)