Reduce activity threshold for non-idle threads.#4191
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4191 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 280 280
Lines 24561 24561
Branches 6555 6555
=======================================
Hits 21719 21719
Misses 2640 2640
Partials 202 202
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mstange
force-pushed
the
lower-activity-threshold
branch
from
c1eb89d to
6a8a051
Compare
canova
approved these changes
Aug 19, 2022
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
I was worried that we would show a lot of threads but thanks for reminding me that we limit to 15 threads anyways. So this will not affect the other profiles that much. I've checked some of them and don't see a huge difference. Looks good to me!
Fixes firefox-devtools#4190. Now we will display more minimally-active threads by default. For the example profile in firefox-devtools#4190, a threshold of 8% would have been sufficient to show the thread. I decided to go down to 5%, but not for any particular reason, just because it was a rounder number. Maybe we'll find out that 8% would have been better after all. Reducing this threshold won't overload the thread list, because we still have the limit of 15 threads.
mstange
force-pushed
the
lower-activity-threshold
branch
from
6a8a051 to
3368a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current production
Deploy preview
Fixes #4190.
Now we will display more minimally-active threads by default.
For the example profile in #4190, a threshold of 8% would have been
sufficient to show the thread. I decided to go down to 5%, but not for
any particular reason, just because it was a rounder number. Maybe we'll
find out that 8% would have been better after all.
Reducing this threshold won't overload the thread list, because we still
have the limit of 15 threads.