Skip to content

Show the self time category breakdown in the sidebar#4195

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
parttimenerd:parttimenerd_show_self_time_categories_in_side_bar
Aug 25, 2022
Merged

Show the self time category breakdown in the sidebar#4195
canova merged 2 commits into
firefox-devtools:mainfrom
parttimenerd:parttimenerd_show_self_time_categories_in_side_bar

Conversation

@parttimenerd

@parttimenerd parttimenerd commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

The self time breakdown for the implementation data is already there, adding it for the category makes especially sense for imported profiles where the implementation data is usually not present.

Sample profile

Current production
Deploy preview

@codecov

codecov Bot commented Aug 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4195 (04a39d4) into main (bb8b23b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 04a39d4 differs from pull request most recent head 5eb3873. Consider uploading reports for the commit 5eb3873 to get more accurate results

@@           Coverage Diff           @@
##             main    #4195   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files         280      280           
  Lines       24561    24564    +3     
  Branches     6555     6557    +2     
=======================================
+ Hits        21719    21722    +3     
  Misses       2640     2640           
  Partials      202      202           
Impacted Files Coverage Δ
src/components/sidebar/CallTreeSidebar.js 85.47% <100.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@canova canova enabled auto-merge August 25, 2022 09:45
@canova canova merged commit 84a1eae into firefox-devtools:main Aug 25, 2022
@canova canova mentioned this pull request Sep 6, 2022
@parttimenerd parttimenerd deleted the parttimenerd_show_self_time_categories_in_side_bar branch September 9, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants