Update all development Yarn dependencies (2022-09-05)#4214
Conversation
| "snapshotFormat": { | ||
| "escapeString": true, | ||
| "printBasicPrototype": true | ||
| }, |
There was a problem hiding this comment.
The new jest defaults to false for these values. This makes it necessary to regenerate all snapshots.
I like printBasicPrototype: false because this makes the snapshots more easily copy-pastable, but not really escapeString: false because the resulting strings are not valid.
But for now I set it both to true so that our snapshots stay the same, because I don't want to make the life of our contributor more complicated.
What do you think?
There was a problem hiding this comment.
It sounds good to me. When we have less PRs in progress, we can revisit this. Would you like to open an issue about it?
|
hey @canova, I'd like that you have a look at my second commit here, and tell me what you think :) thanks! |
Codecov Report
@@ Coverage Diff @@
## main #4214 +/- ##
=======================================
Coverage 88.44% 88.44%
=======================================
Files 281 281
Lines 24587 24587
Branches 6559 6559
=======================================
Hits 21747 21747
Misses 2638 2638
Partials 202 202 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| "snapshotFormat": { | ||
| "escapeString": true, | ||
| "printBasicPrototype": true | ||
| }, |
There was a problem hiding this comment.
It sounds good to me. When we have less PRs in progress, we can revisit this. Would you like to open an issue about it?
2 participants
This is your weekly update of all development Yarn dependencies. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ babel-jest (28.1.3 → 29.0.2, major) · Repo · Changelog · Release · Diff
✳️ jest (28.1.3 → 29.0.1, major) · Repo · Changelog · Release · Diff
✳️ jest-environment-jsdom (28.1.3 → 29.0.1, major) · Repo · Changelog · Release · Diff
✳️ eslint (8.21.0 → 8.23.0, minor) · Repo · Changelog · Release · Diff
✳️ eslint-plugin-react (7.30.1 → 7.31.1, minor) · Repo · Changelog · Release · Diff
✳️ @babel/core (7.18.10 → 7.18.13, patch) · Repo · Changelog · Release · Diff
Depfu will only send you the next scheduled PR once you merge or close this one.
All Depfu comment commands