Skip to content

Do not show a tooltip when the stack index of the hovered sample is null, instead of crashing #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 2 commits into from
Dec 20, 2022
Merged

Do not show a tooltip when the stack index of the hovered sample is null, instead of crashing #4376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb2727
Do not show a tooltip when the stack index of the hovered sample is n…
julienw Dec 15, 2022
8c31162
Merge branch 'main' into 4363-sample-tooltip-crash
julienw Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/components/shared/thread/ActivityGraphFills.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ export class ActivityFillGraphQuerier {
): HoveredPixelState | null {
const {
rangeFilteredThread: { samples, stackTable },
greyCategoryIndex,
} = this.renderedComponentSettings;
const { devicePixelRatio } = window;
const deviceX = Math.round(cssX * devicePixelRatio);
Expand Down Expand Up @@ -437,10 +436,13 @@ export class ActivityFillGraphQuerier {
// iteration - in the first iteration, yPercentage can be == categoryLowerEdge.)
for (const { sample, contribution } of candidateSamples) {
const stackIndex = samples.stack[sample];
const sampleCategory =
stackIndex !== null
? stackTable.category[stackIndex]
: greyCategoryIndex;
if (stackIndex === null) {
console.error(
`Stack index was null for sample index ${sample}, this shouldn't happen normally, please fix your source of data.`
);
continue;
}
const sampleCategory = stackTable.category[stackIndex];
const upperEdgeOfThisSample = upperEdgeOfPreviousSample + contribution;
// Checking the sample category here because there are samples with different
// categories that has y percentage is lower than the upperEdgeOfThisSample.
Expand Down