Remove the optimizations field from frame table#4432
Merged
Conversation
Codecov ReportBase: 88.55% // Head: 88.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4432 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 283 283
Lines 25533 25533
Branches 6879 6879
=======================================
Hits 22611 22611
Misses 2715 2715
Partials 207 207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
canova
force-pushed
the
remove-frame-opt
branch
from
5e71126 to
d229f8c
Compare
julienw
approved these changes
Jan 20, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clean-up!
canova
force-pushed
the
remove-frame-opt
branch
from
d229f8c to
a152c83
Compare
canova
force-pushed
the
remove-frame-opt
branch
from
a152c83 to
f0f3153
Compare
Merged
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 25, 2023
…e r=julienw This requires firefox-devtools/profiler#4432 to be landed and deployed. We bump the profile version in this patch. Afaik we never used the optimizations field of the frame table in the profiler frontend and this pfield was null for more than 3 years (since Bug 1614622). We don't have any plans to make use of it any time soon. It's good to cleanup this field so it doesn't clutter the profile data and we can reduce the profile data size. Differential Revision: https://phabricator.services.mozilla.com/D167290
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jan 26, 2023
…e r=julienw This requires firefox-devtools/profiler#4432 to be landed and deployed. We bump the profile version in this patch. Afaik we never used the optimizations field of the frame table in the profiler frontend and this pfield was null for more than 3 years (since Bug 1614622). We don't have any plans to make use of it any time soon. It's good to cleanup this field so it doesn't clutter the profile data and we can reduce the profile data size. Differential Revision: https://phabricator.services.mozilla.com/D167290
julienw
added a commit
to julienw/perf.html
that referenced
this pull request
Mar 27, 2023
…inux perf and ART This was done in firefox-devtools#4432, but because these importers target a specific version of the gecko profile format, we shouldn't change their structure without upgrading the format too. Fixes firefox-devtools#4547
julienw
added a commit
to julienw/perf.html
that referenced
this pull request
Mar 27, 2023
…inux perf and ART This was done in firefox-devtools#4432, but because these importers target a specific version of the gecko profile format, we shouldn't change their structure without upgrading the format too. Fixes firefox-devtools#4547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend part of this PR is Bug 1615546
This PR removes the "optimizations" field of the frameTable. This hasn't been used since it was implemented (afaik) and it hasn't been provided by the backend since Bug 1614622. It's good to remover this unused field now to save some space in the profile data and profiler memory usage.
Example old processed profile
Example old gecko profiles
Example processed profile with the backend patch
Example gecko profile with the backend patch