Slightly simplify the implementation of the draw log in the canvas mock#4436
Merged
julienw merged 2 commits intoJan 20, 2023
Merged
Conversation
julienw
commented
Jan 20, 2023
| const oldLog = log.slice(); | ||
| log.splice(0, log.length); | ||
| return oldLog; | ||
| return log.splice(0, log.length); |
Contributor
Author
There was a problem hiding this comment.
splice returns the deleted elements
Codecov ReportBase: 88.55% // Head: 88.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
- Coverage 88.55% 88.52% -0.03%
==========================================
Files 283 283
Lines 25535 25506 -29
Branches 6879 6869 -10
==========================================
- Hits 22613 22580 -33
- Misses 2715 2717 +2
- Partials 207 209 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple change that I've made while working on something else. This should bring no visible change to tests, and maybe make them slightly faster.