Make repoPathRegex more permissive.#4438
Closed
mstange wants to merge 1 commit into
Closed
Conversation
It will now accept "revisions" which are git tag names. For example: git:github.com/torvalds/linux:arch/x86/mm/fault.c:v5.15 In this example, the tag name / "revision" is "v5.15". The CORS-URL for this file would then be https://raw.githubusercontent.com/torvalds/linux/v5.15/arch/x86/mm/fault.c
Contributor
|
It's so painful since we moved to the GHE-based environment :-( |
Contributor
Author
|
Ugh, I logged out and back in and re-authed and then closed this PR and reopened it as #4439 but it still doesn't work. |
Contributor
|
It looks like the other one worked finally... |
Contributor
Author
|
Did it? |
Contributor
|
Yeah, I see an error clearly, but the individual tasks were run. Not sure how to make sense out of that! |
Contributor
Author
|
I've force pushed to rebase, and now the error message is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will now accept "revisions" which are git tag names. For example:
git:github.com/torvalds/linux:arch/x86/mm/fault.c:v5.15In this example, the tag name / "revision" is "v5.15". The CORS-URL for this file would then be
https://raw.githubusercontent.com/torvalds/linux/v5.15/arch/x86/mm/fault.c
I'm not planning to use this capability, but maybe it'll be useful for somebody at some point.
I was initially planning to use it for kernel sources in samply, but then I noticed that Ubuntu has its own patches on top of the original kernel source, so I'll need to get the source from somewhere else after all.