Skip to content

Make repoPathRegex more permissive. #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 1 commit into from
Jan 23, 2023
Merged

Make repoPathRegex more permissive. #4439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/test/unit/special-paths.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ describe('parseFileNameFromSymbolication', function () {
path: 'core/fdrm/fx_crypt.cpp',
rev: 'dab1161c861cc239e48a17e1a5d729aa12785a53',
});
expect(
parseFileNameFromSymbolication(
'git:github.com/torvalds/linux:arch/x86/mm/fault.c:v5.15'
)
).toEqual({
type: 'git',
repo: 'github.com/torvalds/linux',
path: 'arch/x86/mm/fault.c',
rev: 'v5.15',
});
});

it('parses s3 paths', function () {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/special-paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export type SourceFileDownloadRecipe =
// Some rust stdlib functions: (https://bugzilla.mozilla.org/show_bug.cgi?id=1717973)
// "/builds/worker/fetches/rustc/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs"
const repoPathRegex =
/^(?<vcs>hg|git):(?<repo>[^:]*):(?<path>[^:]*):(?<rev>[0-9a-f]*)$/;
/^(?<vcs>hg|git):(?<repo>[^:]*):(?<path>[^:]*):(?<rev>.*)$/;
const s3PathRegex =
/^s3:(?<bucket>[^:]*):(?<digest>[0-9a-f]*)\/(?<path>[^:]*):$/;
const cargoPathRegex =
Expand Down