Skip to content

Add config.cache example to webpack.local-config.js note #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 2 commits into from
Jan 26, 2023
Merged

Add config.cache example to webpack.local-config.js note #4446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d30e167
Add `config.cache` example to `webpack.local-config.js` note
kazarmy Jan 24, 2023
97f8244
Shorten sentence
kazarmy Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ To get started clone the repo and get the web application started.
5. Point your browser to [http://localhost:4242](http://localhost:4242).
6. If port `4242` is taken, then you can run the web app on a different port: `FX_PROFILER_PORT=1234 yarn start`

Other [webpack](https://webpack.js.org/configuration/) and [webpack server](https://webpack.js.org/configuration/dev-server/) options can be set in a `webpack.local-config.js` file at the repo root. For example, if you want the server to automatically open the home page, put in there the following code:
Other [webpack](https://webpack.js.org/configuration/) and [webpack server](https://webpack.js.org/configuration/dev-server/) options can be set in a `webpack.local-config.js` file at the repo root. For example, if you want a persistent build cache and the server to automatically open the home page, put in there the following code:

```js
module.exports = function (config, serverConfig) {
config.cache = {
type: 'filesystem',
};
Comment on lines +51 to +53

@julienw julienw Jan 26, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm I wonder if we should have this by default in our config actually. It looks like I considered doing this because I have an open tab on this configuration.
It would be good to get your feedback after a few days using this.

@kazarmy kazarmy Jan 26, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently do plan to find out whether server config changes force a full rebuild, but what is next isn't yet set in stone.

@kazarmy kazarmy Jan 28, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying serverConfig.static roughly triples the cached webpack build time lol

serverConfig.open = true;
};
```
Expand Down