Make the CallTree store a Thread.#4475
Merged
Merged
Conversation
There wasn't really a reason not to do this, since we pass the entire Thread to the constructor. And this makes it easier to use the full thread for other things. For example, for the assembly view, I'll need the frame and func tables as well, to compute the native symbols for a call node.
julienw
approved these changes
Feb 17, 2023
julienw
left a comment
julienw
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me indeed. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There wasn't really a reason not to do this, since we pass the entire Thread to the constructor. And this makes it easier to use the full thread for other things.
For example, for the assembly view, I'll need the frame and func tables as well, to compute information about the native symbols for a call node.