Skip to content

Rename activation generation to scroll generation.#4481

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
mstange:scroll-generation
Feb 20, 2023
Merged

Rename activation generation to scroll generation.#4481
julienw merged 2 commits into
firefox-devtools:mainfrom
mstange:scroll-generation

Conversation

@mstange

@mstange mstange commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

As requested in review comments in #4478.

@mstange mstange requested a review from julienw February 17, 2023 20:34
@mstange mstange self-assigned this Feb 17, 2023
@codecov

codecov Bot commented Feb 17, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@dc8b7cc). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7a34102 differs from pull request most recent head 44d5eb3. Consider uploading reports for the commit 44d5eb3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4481   +/-   ##
=======================================
  Coverage        ?   88.64%           
=======================================
  Files           ?      284           
  Lines           ?    25587           
  Branches        ?     6882           
=======================================
  Hits            ?    22681           
  Misses          ?     2701           
  Partials        ?      205           
Impacted Files Coverage Δ
src/app-logic/url-handling.js 86.55% <ø> (ø)
src/components/app/BottomBox.js 42.42% <ø> (ø)
src/reducers/url-state.js 96.00% <100.00%> (ø)
src/selectors/url-state.js 98.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julienw julienw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@julienw julienw enabled auto-merge (squash) February 20, 2023 13:01
@julienw julienw merged commit 1386366 into firefox-devtools:main Feb 20, 2023
@canova canova mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants