Fix getUsefulTabs to handle cases where the first sample in a thread …#4484
Merged
julienw merged 3 commits intoFeb 22, 2023
Merged
Conversation
Codecov ReportBase: 88.64% // Head: 88.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4484 +/- ##
==========================================
- Coverage 88.64% 88.64% -0.01%
==========================================
Files 284 284
Lines 25587 25591 +4
Branches 6882 6885 +3
==========================================
+ Hits 22681 22684 +3
- Misses 2701 2702 +1
Partials 205 205
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…is null
@padenot shared this profile with me: https://profiler.firefox.com/public/4ne691385vj2vxs3gzrsvvpbnkcne7tm74qgpxr/marker-chart/?globalTrackOrder=0w2&thread=2&v=8
It's not possible to select the parent process track.
The issue is that the first sample is
null, and so this fails inprofiler/src/selectors/per-thread/composed.js
Line 95 in 1386366
I'm not sure how a sample can be
nullwhen coming from Gecko, possibly because of sanitization?I know samply can do this too. As a result this fixes #4364 too.
Production / Deploy preview (click on the parent process)
Production / Deploy preview (click on WebCOOP track)